On Tue, 17 Jun 2025 08:39:49 GMT, Anton Artemov <d...@openjdk.org> wrote:
> This PR contains changes for the 1st phase of the `LockingMode` flag
> obsoletion.
>
> The work is done by @fbredber, I have taken it over and am finishing it while
> he's on vacation.
>
> In the 1st phase one keeps the `LockingMode` variable in all places, but
> makes it non-settable from the command line. All the C1 and C2 code related
> to legacy locking will still be in place (but as dead code) and removed later
> (phase 2).
>
> Lightweight locking is the default locking from now on.
>
> Tested in tiers 1 - 7.
test/jdk/java/lang/Thread/virtual/Parking.java line 388:
> 386: @ParameterizedTest
> 387: @ValueSource(booleans = { true, false })
> 388: @DisabledIf("LockingMode#isLegacy")
Would you mind checking if the import DisabledIf can be removed from these
tests? I think we only used it to conditionally run when not legacy mode.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25847#discussion_r2161946231
