On Tue, 3 Jun 2025 20:09:51 GMT, Naoto Sato <na...@openjdk.org> wrote:

>> Volkan Yazici has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Fix missing `java.io.Reader` import in `Ktab`
>
> I was thinking if someone made a typo for "stdin.encoding" and then it 
> unknowingly defaults to the fallback. Turned out it immediately fails with 
> "java.lang.IllegalArgumentException: Null charset name" so I think it should 
> be OK.

@naotoj, @turbanoff, @wangweij, @plummercj, @AlanBateman, thanks so much for 
the reviews.

`tier1,2,3` pass – results are attached to the ticket.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/25544#issuecomment-2969879685

Reply via email to