On Wed, 12 Mar 2025 11:15:29 GMT, Maurizio Cimadamore <mcimadam...@openjdk.org> wrote:
>> Quan Anh Mai has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains nine additional >> commits since the last revision: >> >> - Merge branch 'master' into segmentallocate >> - revert changes to CallocArena >> - Merge branch 'master' into segmentallocate >> - copyright >> - Merge branch 'master' into segmentallocate >> - wrong init >> - move segment instance creation to SegmentFactories >> - address review >> - improve the implementation of SegmentFactories::allocateSegment > > test/micro/org/openjdk/bench/java/lang/foreign/AllocTest.java line 26: > >> 24: package org.openjdk.bench.java.lang.foreign; >> 25: >> 26: import java.lang.foreign.*; > > I believe it would be better to leave the imports alone -- as all the other > benchmarks also use the "more explicit" style. I have expanded the import section, please reapprove this PR, thanks a lot. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22610#discussion_r1993069941
