On Wed, 20 Nov 2024 14:13:59 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:
>> Aleksei Efimov has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Docs and comments update
>> - Revert VersionHelper.createThread removal
>
> src/jdk.naming.rmi/share/classes/module-info.java line 63:
>
>> 61: * <p> Downloading a factory class from a {@linkplain
>> javax.naming.Reference#getFactoryClassLocation()
>> 62: * location} specified in the reference can be supported by a custom
>> implementation of {@link
>> 63: * javax.naming.spi.ObjectFactoryBuilder}. Unless an {@link
>> javax.naming.spi.ObjectFactoryBuilder
>
> Suggestion:
>
> * javax.naming.spi.ObjectFactoryBuilder}. If a location is specified, then
> * unless an {@link javax.naming.spi.ObjectFactoryBuilder
Thank you changed in
[991994d](https://github.com/openjdk/jdk/pull/22154/commits/991994da64bcc5c2f8bfb5cf8704e926948153f0)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22154#discussion_r1850622248
