On Wed, 3 Jul 2024 16:45:51 GMT, Alexey Semenyuk <asemen...@openjdk.org> wrote:

>> Vanitha B P has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   8325525 Addressed review comments
>
> test/jdk/tools/jpackage/apps/ThirdPartyAppLauncher.java line 34:
> 
>> 32:         ProcessBuilder processBuilder = new ProcessBuilder("regedit");
>> 33:         Process process = processBuilder.start();
>> 34:         logger.info("RegEdit id=" + process.pid());
> 
> Logging is excessive and not applicable here as it can be redirected. The 
> test shall print the PID to stdout.

Sure, will print the PID using sysout

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19536#discussion_r1665785034

Reply via email to