On Thu, 22 Jun 2023 19:39:16 GMT, Brian Burkhalter <b...@openjdk.org> wrote:
>> Brian Burkhalter has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8222329: rephrase "full" to "no elements remaining" > > src/java.base/share/classes/java/io/Reader.java line 193: > >> 191: * changes made are the results of a put operation. No flipping or >> 192: * rewinding of the buffer is performed. If the specified character >> 193: * buffer is full, then no characters will be read and zero will be > > Instead of "is full" here, it would be more consistent to state "has no > remaining elements". For a buffer that is being written into, it sounds a bit odd to say "no remaining elements"; that phrasing is ok for reading/getting bytes but doesn't sound like there's free space to put anything. Would "no remaining free elements" or "no remaining available elements" be better? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/14616#discussion_r1239042484
