On Thu, 16 Jun 2022 21:21:36 GMT, Joe Darcy <da...@openjdk.org> wrote:

> Whatever the motivation for how this method was coded when added in JDK 8, 
> since Executable is now a sealed class with Constructor and Method the only 
> allowed subclasses, getParameterCount can be coded as an normal abstract 
> method. (The implementation of getParameterCount in Method and Constructor 
> use fields private to each of those classes so the code cannot easily be 
> shared in Executable).
> 
> Please also review the small accompanying CSR: 
> https://bugs.openjdk.org/browse/JDK-8288630

Change looks fine to me. The copyright year on this file will need an update, 
which I guess you would be doing before integrating this.

-------------

Marked as reviewed by jpai (Reviewer).

PR: https://git.openjdk.org/jdk/pull/9192

Reply via email to