Hi goblinrs,

The patch looks mostly correct to me. I support installing it after amendments in the repository.

I see the following minor issues:

- The hunk that adds Harmony to the Ironclad|Linux|GNU|GNU/* group sets $LIBC, but this doesn't seem to be used anywhere. - I suggest not squashing UNAME_MACHINE into arm. I think that this entire block can safetly become GUESS=$UNAME_MACHINE-unknown-linux-ohos.
- No test in testsuite/config-guess.data.
- This is not a `git format-patch -1'-style patch.
- Is the `-linux' in the triplet correct?

--
With Valediction,
Kamila Szewczyk (https://iczelia.net)

Attachment: OpenPGP_0xC868F0B6DE38409D.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature

Reply via email to