On Thu, Apr 4, 2024, at 6:25 PM, Jacob Bachmeyer wrote:
> Zack Weinberg wrote:
>> - $CC_FOR_BUILD -o "$dummy" "$dummy.c" &&
>> - dummyarg=`echo "$UNAME_RELEASE" | sed -n 's/\([0-9]*\).*/\1/p'` &&
>> - SYSTEM_NAME=`"$dummy" "$dummyarg"` &&
>> + SYSTEM_TYPE="`$CC_FOR_BUILD -E - < "$dummy.c" |
>> + sed -n 's/^ *SYSTYPE *= *//p'`" &&
>> + SYSTEM_REL="`echo "$UNAME_RELEASE" | sed -n 's/\([0-9]*\).*/\1/p'`" &&
>> + SYSTEM_NAME="mips-mips-riscos${SYSTEM_REL}${SYSTEM_TYPE}" &&
>>
>
> You have tripped up on a known portability issue here: due to bugs in
> various shells, there is no portable way to use double quotes inside
> double-quoted backticks.
Ugh. Will fix.
> all other assignments avoid unneeded quotes.
I still vehemently object to a coding style which forces people to remember
when the quotes are unnecessary, but this is not the time for that argument.
Revised patch series shortly.
zw
