On Sat, Jul 03, 2021 at 11:52:18AM +0300, Ozkan Sezer wrote: > On 7/3/21, Jacob Bachmeyer <jcb62...@gmail.com> wrote: > > Ozkan Sezer wrote: > >> The attached patch replaces a handful of POSIX $(xx) with classic `xx` > >> in config.sub. This is in line with the recent config.guess change i.e. > >> commit d70c4fa934de: > >> http://git.savannah.gnu.org/gitweb/?p=config.git;a=commit;h=d70c4fa934de164178054c3a60aaa0024ed07c91 > >> > >> -- > >> O.S. > > > > While doing this, also normalizing the quoting in the `echo FOO | sed > > ...` would be nice. Some cases quote the argument to echo and some do > > not. At runtime it probably does not matter because the substituted > > values will never contain whitespace, but quoting them all would make > > shellcheck more useful. > > > > Also see patch 5 in the recent "v2" series for the marker line to > > prevent shellcheck from complaining about backticks. It must be placed > > before the first executable line (the timestamp variable assignment) for > > shellcheck to apply it to the entire script. > > > > > > -- Jacob > > Done, as best as I can: Attached patches.
Merged, thanks. -- ldv
