Sorry! I added it the the patterns above for consistency, and added a test so I won't forget this case in the future :).

On 08/07/18 22:06, Ben Elliston wrote:
On Wed, Aug 01, 2018 at 11:39:11PM -0400, John Ericson wrote:

+2018-08-01  John Ericson  <john.ericson@obsidian.systems>
+
+       * config.sub: Remove some approximately sh* dead code
+
+    Evidentally this has been dead since its original incarnation in
+    cedea588f577fdf78ff4645543907ee6f7babae5.
Approximately is correct. ;-) You can't delete the sh[23]ele cases
here without covering them somewhere else.

Cheers, Ben

>From f03da559e3ac2cf9eba3b297c7fcc6850b3fc31c Mon Sep 17 00:00:00 2001
Message-Id: 
<f03da559e3ac2cf9eba3b297c7fcc6850b3fc31c.1533695258.git.John.Ericson@Obsidian.Systems>
From: John Ericson <John.Ericson@Obsidian.Systems>
Date: Fri, 3 Aug 2018 15:58:00 -0400
Subject: [PATCH]    * config.sub: Remove some approximately sh* dead code
To: config-patches@gnu.org

Evidentally this has been dead since its original incarnation in
cedea588f577fdf78ff4645543907ee6f7babae5.
---
 ChangeLog                 | 7 +++++++
 config.sub                | 7 ++-----
 testsuite/config-sub.data | 2 ++
 3 files changed, 11 insertions(+), 5 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 2d68917..80b41d1 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2018-08-01  John Ericson  <john.ericson@obsidian.systems>
+
+       * config.sub: Remove some approximately sh* dead code
+
+    Evidentally this has been dead since its original incarnation in
+    cedea588f577fdf78ff4645543907ee6f7babae5.
+
 2018-08-08  John Ericson  <john.ericson@obsidian.systems>
 
        * config.sub (tile*): Only set 'os' to -linux-gnu if unset.
diff --git a/config.sub b/config.sub
index dddd27d..97d38aa 100755
--- a/config.sub
+++ b/config.sub
@@ -630,7 +630,7 @@ case $basic_machine in
        | riscv | riscv32 | riscv64 \
        | rl78 | rx \
        | score \
-       | sh | sh[1234] | sh[24]a | sh[24]aeb | sh[23]e | sh[234]eb | sheb | 
shbe | shle | sh[1234]le | sh3ele \
+       | sh | sh[1234] | sh[24]a | sh[24]aeb | sh[23]e | sh[234]eb | sheb | 
shbe | shle | sh[1234]le | sh[23]ele \
        | sh64 | sh64le \
        | sparc | sparc64 | sparc64b | sparc64v | sparc86x | sparclet | 
sparclite \
        | sparcv8 | sparcv9 | sparcv9b | sparcv9v \
@@ -769,7 +769,7 @@ case $basic_machine in
        | rl78-* | romp-* | rs6000-* | rx-* \
        | score-* \
        | sh-* | sh[1234]-* | sh[24]a-* | sh[24]ae[lb]-* | sh[23]e-* | 
she[lb]-* | sh[lb]e-* \
-       | sh[1234]e[lb]-* |  sh[12345][lb]e-* | sh3ele-* | sh64-* | sh64le-* \
+       | sh[1234]e[lb]-* |  sh[12345][lb]e-* | sh[23]ele-* | sh64-* | sh64le-* 
\
        | sparc-* | sparc64-* | sparc64b-* | sparc64v-* | sparc86x-* | 
sparclet-* \
        | sparclite-* \
        | sparcv8-* | sparcv9-* | sparcv9b-* | sparcv9v-* | sv1-* | sx*-* \
@@ -1257,9 +1257,6 @@ case $basic_machine in
        we32k)
                basic_machine=we32k-att
                ;;
-       sh[1234] | sh[24]a | sh[24]aeb | sh[34]eb | sh[1234]le | sh[23]ele)
-               basic_machine=sh-unknown
-               ;;
        cydra)
                basic_machine=cydra-cydrome
                ;;
diff --git a/testsuite/config-sub.data b/testsuite/config-sub.data
index 96d805b..1491c40 100644
--- a/testsuite/config-sub.data
+++ b/testsuite/config-sub.data
@@ -454,6 +454,8 @@ sh2le                                               
sh2le-unknown-none
 sh2                                            sh2-unknown-none
 sh3eb-elf                                      sh3eb-unknown-elf
 sh3e-elf                                       sh3e-unknown-elf
+sh2ele-elf                                     sh2ele-unknown-elf
+sh2ele                                         sh2ele-unknown-none
 sh3ele-elf                                     sh3ele-unknown-elf
 sh3ele                                         sh3ele-unknown-none
 sh3-elf                                                sh3-unknown-elf
-- 
2.17.1

_______________________________________________
config-patches mailing list
config-patches@gnu.org
https://lists.gnu.org/mailman/listinfo/config-patches

Reply via email to