Mike,
I think this clearly needs to be fixed. At the very least the logging
need to be more selective. I would also advocate changing the isStale()
behavior in the CVS HEAD. I see no benefit in calling close on a closed
connection. What do you think?
Oleg
On Thu, 2004-05-27 at 19:16, Michael Becke wrote:
> > Mike, Any idea why closed connection is considered stale?
> >
> > <snip> protected boolean isStale() { boolean isStale = true; if
> > (isOpen) { // the connection is open, but now we have to see if we
> > can read it // assume the connection is not stale. isStale = false;
> > </snip>
>
> It's just poor logging.
>
> public boolean isOpen() {
> if (used && isStaleCheckingEnabled() && isStale()) {
> LOG.debug("Connection is stale, closing...");
> close();
> }
> return isOpen;
> }
>
> isOpen() does not differentiate between stale and closed. If the
> connection is closed isStale() will return true. In the case at hand it
> appears that the connections are actually closed, but the logging makes
> that unclear.
>
> Mike
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
