[
https://issues.apache.org/jira/browse/HADOOP-12540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Nauroth updated HADOOP-12540:
-----------------------------------
Status: Open (was: Patch Available)
Hi [~gouravk]. Yes, I think this will work fine overall. A few nitpicks:
# The attached patch file appears to be UTF-16. Please make sure to save as
ASCII in the next revision. I tested the current patch revision by running
{{iconv -f UTF-16 -t ASCII HADOOP-12540.01.patch}}.
# Please remove the {{System.out}} call, which I assume is left over from
debugging.
# There is a small chance of a resource leak if {{fs.create}} succeeds, but
then {{testAccount.acquireShortLease}} throws an exception. I recommend moving
both the {{fs.create}} and the {{testAccount.acquireShortLease}} within the
first {{try}} block.
Thank you!
> TestAzureFileSystemInstrumentation#testClientErrorMetrics fails
> intermittently due to assumption that a lease error will be thrown.
> -----------------------------------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-12540
> URL: https://issues.apache.org/jira/browse/HADOOP-12540
> Project: Hadoop Common
> Issue Type: Bug
> Components: azure, test
> Reporter: Chris Nauroth
> Assignee: Gaurav Kanade
> Attachments: HADOOP-12540.01.patch
>
>
> HADOOP-12508 changed the behavior of an Azure Storage lease violation during
> deletes. It appears that
> {{TestAzureFileSystemInstrumentation#testClientErrorMetrics}} is partly
> dependent on the old behavior for simulating an error to be tracked by the
> metrics system. I am seeing intermittent failures in this test.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
