[
https://issues.apache.org/jira/browse/HADOOP-10787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14978072#comment-14978072
]
Varun Vasudev commented on HADOOP-10787:
----------------------------------------
[~aw] - any idea what's happening with the failing test?
I tried to run it on my machine and here's what I get(all these runs were with
the patch applied) -
1) On my mac
{code}
[exec] 1..3
[exec] not ok 1 hadoop_add_common_to_classpath (negative)
[exec] # (from function `freetheclasses' in file
hadoop_add_common_to_classpath.bats, line 27,
[exec] # in test file hadoop_add_common_to_classpath.bats, line 45)
[exec] # `freetheclasses' failed
[exec] # bindir:
/Users/vvasudev/Workspace/apache/hadoop/hadoop-common-project/hadoop-common/src/test/scripts
[exec] # /var/folders/n1/klkrb91135d8s9xl7m4gcsgw0000gp/T/bats.39050.src:
line 27: unset: `/Users/vvasudev/Workspace/current-hadoop': not a valid
identifier
[exec] not ok 2 hadoop_add_common_to_classpath (positive)
[exec] # (from function `freetheclasses' in file
hadoop_add_common_to_classpath.bats, line 27,
[exec] # in test file hadoop_add_common_to_classpath.bats, line 53)
[exec] # `freetheclasses' failed
[exec] # bindir:
/Users/vvasudev/Workspace/apache/hadoop/hadoop-common-project/hadoop-common/src/test/scripts
[exec] # /var/folders/n1/klkrb91135d8s9xl7m4gcsgw0000gp/T/bats.39050.src:
line 27: unset: `/Users/vvasudev/Workspace/current-hadoop': not a valid
identifier
[exec] not ok 3 hadoop_add_common_to_classpath (build paths)
[exec] # (from function `freetheclasses' in file
hadoop_add_common_to_classpath.bats, line 27,
[exec] # in test file hadoop_add_common_to_classpath.bats, line 63)
[exec] # `freetheclasses' failed
[exec] # bindir:
/Users/vvasudev/Workspace/apache/hadoop/hadoop-common-project/hadoop-common/src/test/scripts
[exec] # /var/folders/n1/klkrb91135d8s9xl7m4gcsgw0000gp/T/bats.39050.src:
line 27: unset: `/Users/vvasudev/Workspace/current-hadoop': not a valid
identifier
[exec] Running bats -t hadoop_add_javalibpath.bats
{code}
2) On a Linux VM
{code}
[exec] Running bats -t hadoop_add_to_classpath_toolspath.bats
[exec] 1..5
[exec] ok 1 hadoop_add_to_classpath_toolspath (nothing)
[exec] ok 2 hadoop_add_to_classpath_toolspath (none)
[exec] not ok 3 hadoop_add_to_classpath_toolspath (only)
[exec] # (from function `hadoop_add_to_classpath_toolspath' in file
../../main/bin/hadoop-functions.sh, line 970,
[exec] # in test file hadoop_add_to_classpath_toolspath.bats, line 52)
[exec] # `hadoop_add_to_classpath_toolspath' failed
[exec] # bindir:
/home/varun/hadoop/hadoop-common-project/hadoop-common/src/test/scripts
[exec] # DEBUG: Adding HADOOP_TOOLS_PATH to CLASSPATH
[exec] not ok 4 hadoop_add_to_classpath_toolspath (1+1)
[exec] # (from function `hadoop_add_to_classpath_toolspath' in file
../../main/bin/hadoop-functions.sh, line 970,
[exec] # in test file hadoop_add_to_classpath_toolspath.bats, line 61)
[exec] # `hadoop_add_to_classpath_toolspath' failed
[exec] # bindir:
/home/varun/hadoop/hadoop-common-project/hadoop-common/src/test/scripts
[exec] # DEBUG: Adding HADOOP_TOOLS_PATH to CLASSPATH
[exec] ok 5 hadoop_add_to_classpath_toolspath (3+2)
[exec] Running bats -t hadoop_add_to_classpath_userpath.bats
[exec] 1..7
[exec] not ok 1 hadoop_add_to_classpath_userpath (nothing)
[exec] # (from function `freetheclasses' in file
hadoop_add_to_classpath_userpath.bats, line 25,
[exec] # in test file hadoop_add_to_classpath_userpath.bats, line 38)
[exec] # `freetheclasses' failed
[exec] # bindir:
/home/varun/hadoop/hadoop-common-project/hadoop-common/src/test/scripts
[exec] # /tmp/bats.24440.src: line 25: unset:
`/var/hadoop/tez-conf:/var/hadoop/tez-0.7.0-minimal/*:/var/hadoop/tez-0.7.0-minimal/lib/*':
not a valid identifier
[exec] not ok 2 hadoop_add_to_classpath_userpath (none)
[exec] # (from function `freetheclasses' in file
hadoop_add_to_classpath_userpath.bats, line 25,
[exec] # in test file hadoop_add_to_classpath_userpath.bats, line 44)
[exec] # `freetheclasses' failed
[exec] # bindir:
/home/varun/hadoop/hadoop-common-project/hadoop-common/src/test/scripts
[exec] # /tmp/bats.24440.src: line 25: unset:
`/var/hadoop/tez-conf:/var/hadoop/tez-0.7.0-minimal/*:/var/hadoop/tez-0.7.0-minimal/lib/*':
not a valid identifier
[exec] not ok 3 hadoop_add_to_classpath_userpath (only)
[exec] # (from function `freetheclasses' in file
hadoop_add_to_classpath_userpath.bats, line 25,
[exec] # in test file hadoop_add_to_classpath_userpath.bats, line 51)
[exec] # `freetheclasses' failed
[exec] # bindir:
/home/varun/hadoop/hadoop-common-project/hadoop-common/src/test/scripts
[exec] # /tmp/bats.24440.src: line 25: unset:
`/var/hadoop/tez-conf:/var/hadoop/tez-0.7.0-minimal/*:/var/hadoop/tez-0.7.0-minimal/lib/*':
not a valid identifier
[exec] not ok 4 hadoop_add_to_classpath_userpath (classloader)
[exec] # (from function `freetheclasses' in file
hadoop_add_to_classpath_userpath.bats, line 25,
[exec] # in test file hadoop_add_to_classpath_userpath.bats, line 59)
[exec] # `freetheclasses' failed
[exec] # bindir:
/home/varun/hadoop/hadoop-common-project/hadoop-common/src/test/scripts
[exec] # /tmp/bats.24440.src: line 25: unset:
`/var/hadoop/tez-conf:/var/hadoop/tez-0.7.0-minimal/*:/var/hadoop/tez-0.7.0-minimal/lib/*':
not a valid identifier
[exec] not ok 5 hadoop_add_to_classpath_userpath (1+1 dupe)
[exec] # (from function `freetheclasses' in file
hadoop_add_to_classpath_userpath.bats, line 25,
[exec] # in test file hadoop_add_to_classpath_userpath.bats, line 68)
[exec] # `freetheclasses' failed
[exec] # bindir:
/home/varun/hadoop/hadoop-common-project/hadoop-common/src/test/scripts
[exec] # /tmp/bats.24440.src: line 25: unset:
`/var/hadoop/tez-conf:/var/hadoop/tez-0.7.0-minimal/*:/var/hadoop/tez-0.7.0-minimal/lib/*':
not a valid identifier
[exec] not ok 6 hadoop_add_to_classpath_userpath (3+2 after)
[exec] # (from function `freetheclasses' in file
hadoop_add_to_classpath_userpath.bats, line 25,
[exec] # in test file hadoop_add_to_classpath_userpath.bats, line 79)
[exec] # `freetheclasses' failed
[exec] # bindir:
/home/varun/hadoop/hadoop-common-project/hadoop-common/src/test/scripts
[exec] # /tmp/bats.24440.src: line 25: unset:
`/var/hadoop/tez-conf:/var/hadoop/tez-0.7.0-minimal/*:/var/hadoop/tez-0.7.0-minimal/lib/*':
not a valid identifier
[exec] not ok 7 hadoop_add_to_classpath_userpath (3+2 before)
[exec] # (from function `freetheclasses' in file
hadoop_add_to_classpath_userpath.bats, line 25,
[exec] # in test file hadoop_add_to_classpath_userpath.bats, line 90)
[exec] # `freetheclasses' failed
[exec] # bindir:
/home/varun/hadoop/hadoop-common-project/hadoop-common/src/test/scripts
[exec] # /tmp/bats.24440.src: line 25: unset:
`/var/hadoop/tez-conf:/var/hadoop/tez-0.7.0-minimal/*:/var/hadoop/tez-0.7.0-minimal/lib/*':
not a valid identifier
[exec] Running bats -t hadoop_basic_init.bats
{code}
> Rename/remove non-HADOOP_*, etc from the shell scripts
> ------------------------------------------------------
>
> Key: HADOOP-10787
> URL: https://issues.apache.org/jira/browse/HADOOP-10787
> Project: Hadoop Common
> Issue Type: Improvement
> Components: scripts
> Affects Versions: 3.0.0
> Reporter: Allen Wittenauer
> Assignee: Allen Wittenauer
> Priority: Blocker
> Labels: scripts
> Attachments: HADOOP-10787.00.patch, HADOOP-10787.01.patch,
> HADOOP-10787.02.patch, HADOOP-10787.03.patch
>
>
> We should make an effort to clean up the shell env var name space by removing
> unsafe variables. See comments for list.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
