[ 
https://issues.apache.org/jira/browse/HADOOP-12448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris Nauroth updated HADOOP-12448:
-----------------------------------
    Attachment: HADOOP-12448.002.patch

This is a good idea.  It's probably helpful for stable parallel test execution. 
 (HADOOP-11984).

However, -1 for patch v001.  This would fail on Windows.  The path strings 
constructed for the files would not be valid URI syntax due to the drive spec.  
There is a point in the tests where the path strings are converted back to a 
{{URI}}, and this causes an exception to be thrown.

I took the liberty of making a small tweak and verifying that it passes on Mac 
and Windows.  I'm attaching it as v002.

Thanks, [~cmccabe]!  Maybe another committer can review and +1, since I have 
sullied myself by touching the patch?  :-)

> TestTextCommand: use mkdirs rather than mkdir to create test directory
> ----------------------------------------------------------------------
>
>                 Key: HADOOP-12448
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12448
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 2.8.0
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>         Attachments: HADOOP-12448.001.patch, HADOOP-12448.002.patch
>
>
> TestTextCommand should use mkdirs rather than mkdir to create the test 
> directory.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to