[
https://issues.apache.org/jira/browse/HADOOP-12355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14731060#comment-14731060
]
Kengo Seki commented on HADOOP-12355:
-------------------------------------
LGTM, +1 non-binding.
> test-patch TAP plugin should use ${SED} instead of sed
> ------------------------------------------------------
>
> Key: HADOOP-12355
> URL: https://issues.apache.org/jira/browse/HADOOP-12355
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: yetus
> Affects Versions: HADOOP-12111
> Reporter: Kengo Seki
> Assignee: Jagadesh Kiran N
> Priority: Trivial
> Labels: newbie
> Attachments: HADOOP-12355.HADOOP-12111.00.patch
>
>
> for consistency and platform compatibility.
> {code}
> 54 if [[ -n "${filenames}" ]]; then
> 55 module_failed_tests=$(echo "${filenames}" \
> 56 | sed -e "s,${TAP_LOG_DIR},,g" -e s,^/,,g )
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
