[
https://issues.apache.org/jira/browse/HADOOP-12249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14648357#comment-14648357
]
Sean Busbey commented on HADOOP-12249:
--------------------------------------
nit:
{code}
+MYNAME="${BASH_SOURCE-$0}"
+
{code}
we repeat this phrase a lot. Is there a compatibility reason we need MYNAME to
exist rather than e.g. using BASH_SOURCE directly?
+1 (non-binding)
> pull argument parsing into a function
> -------------------------------------
>
> Key: HADOOP-12249
> URL: https://issues.apache.org/jira/browse/HADOOP-12249
> Project: Hadoop Common
> Issue Type: Improvement
> Components: scripts
> Affects Versions: 3.0.0
> Reporter: Allen Wittenauer
> Assignee: Allen Wittenauer
> Labels: scripts, shell
> Attachments: HADOOP-12249.00.patch, HADOOP-12294.01.patch
>
>
> In order to enable significantly better unit testing as well as enhanced
> functionality, large portions of *-config.sh should be pulled into functions.
> See first comment for more.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
