[
https://issues.apache.org/jira/browse/HADOOP-12198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14635999#comment-14635999
]
Chris Nauroth commented on HADOOP-12198:
----------------------------------------
Hi [~aw]. This looks good. I'm +1 for committing v05.
This is also my first time reading the HADOOP-12226 code for calculating
{{CHANGED_UNION_MODULES}} which is already committed, and either I'm
misunderstanding or perhaps there is a bug here. It walks up the ancestry of
the modules in the file system to find a common ancestor, assuming that
building the ancestor builds all children (recursively). However, some
projects have a child module that is not built when the parent builds.
I'll use Hive as an example. It defines an itests module for integration tests.
https://github.com/apache/hive/blob/master/itests/pom.xml
The itests module is not listed in {{<modules>}} at the root, so building the
root does not build itests.
https://github.com/apache/hive/blob/master/pom.xml#L33-54
If we consider a patch that includes code changes in both common and itests,
then the union would be calculated as the project root, but building at the
root wouldn't actually build itests.
What is your take on this? Is this something that needs improvement here, or
do you expect that it's the job of each project's personality file to know
about a special case like this and avoid referencing {{CHANGED_UNION_MODULES}}?
> patches that hit multiple modules may need to build at root
> -----------------------------------------------------------
>
> Key: HADOOP-12198
> URL: https://issues.apache.org/jira/browse/HADOOP-12198
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: yetus
> Affects Versions: HADOOP-12111
> Reporter: Allen Wittenauer
> Assignee: Allen Wittenauer
> Attachments: HADOOP-12198.HADOOP-12111.00.patch,
> HADOOP-12198.HADOOP-12111.02.patch, HADOOP-12198.HADOOP-12111.03.patch,
> HADOOP-12198.HADOOP-12111.03.patch, HADOOP-12198.HADOOP-12111.04.patch,
> HADOOP-12198.HADOOP-12111.05.patch
>
>
> Patches that introduce dependencies on other modules (e.g., HADOOP-12180)
> need to effectively be built at root.
> There is a good chance this type of logic will need to be done on a
> per-project basis.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
