[
https://issues.apache.org/jira/browse/HADOOP-12171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14610828#comment-14610828
]
stack commented on HADOOP-12171:
--------------------------------
fullClassNameToTraceString looks like utility that belongs in htrace rather
than in hadoop rpc util. Could add it here for now deprecated to be replaced
with htrace implementation.
Call it toTraceString or toTraceName or toTraceKey ... since what is passed in
is not classname, we do more than just shorten the passed String, and our
output is used keying the trace.
Otherwise, LGTM [~cmccabe]
> Shorten overly-long htrace span names for server
> ------------------------------------------------
>
> Key: HADOOP-12171
> URL: https://issues.apache.org/jira/browse/HADOOP-12171
> Project: Hadoop Common
> Issue Type: Bug
> Components: tracing
> Affects Versions: 2.6.0
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Attachments: HADOOP-12171.001.patch
>
>
> Shorten overly-long htrace span names for the server. For example,
> {{org.apache.hadoop.hdfs.protocol.ClientProtocol.create}} should be
> {{ClientProtocol#create}} instead.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
