[
https://issues.apache.org/jira/browse/HADOOP-12036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14596633#comment-14596633
]
Alan Burlison commented on HADOOP-12036:
----------------------------------------
* The first item is needed for 64-bit builds on Solaris. That's because
CMAKE_SYSTEM_PROCESSOR is the same as the output of 'uname -p', which 'i386' on
Solaris x86 for example, because we support both 32 and 64 bit executables
simultaneously. We have to fake it up this way to get CMake to build 64 bit.
That's what the comment above the block in question is saying. Horrid, yes.
* The second item makes good sense, I'll swap the logic around to assume gcc
flags by default.
* I've dug down a little further into the standard CMake library detection
code, and to be honest it's surprising it works at all on Solaris for LP64
libraries. It doesn't use the right LP64 subdirectories when searching for
libraries and I suspect it only works at all because we currently ship both 32
and 64 versions of most everything. When we eventually drop 32-bit versions I
think the current implementation will just stop working on Solaris. Also, from
a cursory glance the custom code in the Hadoop CMake files for libraries like
snappy only partly improves things in this area as it still hard-codes the
Linux scheme for 64-bit library directories. I think I might be able to
persuade the standard CMake find_library do do the right thing, I'll keep
digging.
> Consolidate all of the cmake extensions in one directory
> --------------------------------------------------------
>
> Key: HADOOP-12036
> URL: https://issues.apache.org/jira/browse/HADOOP-12036
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Allen Wittenauer
> Assignee: Alan Burlison
> Attachments: HADOOP-12036.001.patch
>
>
> Rather than have a half-dozen redefinitions, custom extensions, etc, we
> should move them all to one location so that the cmake environment is
> consistent between the various native components.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
