[ 
https://issues.apache.org/jira/browse/HADOOP-7817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14578903#comment-14578903
 ] 

kanaka kumar avvaru commented on HADOOP-7817:
---------------------------------------------

Thanks for the review [~vinayrpet]. I have moved the test code to 
{{TestLocalFileSystem}} and handled the comments except the first one to close 
the fs. 

We can close {{FileSystem}} by making  {{fileSys}} static in a method with 
annotation {{@AfterClass}} but I felt it may be un related change for this JIRA 
context as it's an old file and some other test classes for example 
{{TestCryptoStreamsForLocalFS}} are also not closing localFS. 
So, we can file a separate JIRA to handle this in all such files. What is your 
opinion?



> RawLocalFileSystem.append() should give FSDataOutputStream with accurate 
> .getPos()
> ----------------------------------------------------------------------------------
>
>                 Key: HADOOP-7817
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7817
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs
>    Affects Versions: 1.0.0
>            Reporter: Kristofer Tomasette
>            Assignee: kanaka kumar avvaru
>            Priority: Minor
>         Attachments: HADOOP-7817-01.patch, HADOOP-7817-02.patch, 
> HADOOP-7817.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> When RawLocalFileSyste.append() is called it returns an FSDataOutputStream 
> whose .getPos() returns 0.
> getPos() should return position in the file where appends will start writing.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to