[ 
https://issues.apache.org/jira/browse/HADOOP-12066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14576965#comment-14576965
 ] 

Vinayakumar B commented on HADOOP-12066:
----------------------------------------

bq. Oh bad, the change involves into HDFS side so this needs to be converted.
Since its just the Utility change, which is more in Common side, and in HDFS 
only calls are replaced with Utility with one-line changes, I think Its fine to 
be in Common. 
Anyway If needed to move to HDFS project, I am OK with that too.

Coming to patch,
Is the intention of Jira is just to allow configuring the factory class? and 
generate the raw coders from the configured factory classes instead of directly 
calling constructors?.

Just confused with creating codecs based on codec names from ecschema.


There are some small formatting changes to be done on changed lines. Some lines 
seems to be very long.

Other changes looks good though.

> Allow to configure RS and XOR raw coders 
> -----------------------------------------
>
>                 Key: HADOOP-12066
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12066
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: io
>            Reporter: Kai Zheng
>            Assignee: Kai Zheng
>         Attachments: HADOOP-12066-HDFS-7285-v1.patch
>
>
> This is to allow configuring RS and XOR raw coders as they're the basic ones 
> and used in other advanced codecs like HH and LRC, and we're having both 
> implementations in Java and native.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to