[
https://issues.apache.org/jira/browse/HADOOP-12072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14576238#comment-14576238
]
Kengo Seki commented on HADOOP-12072:
-------------------------------------
[~brahmareddy] thanks for taking this issue! I have two comments:
1. capacity-scheduler.xml does not need special treatment, because its
structure is the same as other configuration XML files (configuration ->
property -> name/value).
2. I think you already know, it's not determined by the file name whether a
file is the fair scheduler allocation file or not, because users can specify
its name via the yarn.scheduler.fair.allocation.file property. So we must
examine the root element to determine the kinds of the file.
> conftest raises a false alarm over the fair scheduler configuration file
> ------------------------------------------------------------------------
>
> Key: HADOOP-12072
> URL: https://issues.apache.org/jira/browse/HADOOP-12072
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Kengo Seki
> Assignee: Brahma Reddy Battula
>
> hadoop conftest subcommand validates the XML files in ${HADOOP_CONF_DIR} by
> default, and assumes the root element of the XML is <configuration>.
> But it is popular to put the fair scheduler configuration file as
> ${HADOOP_CONF_DIR}/fair-scheduler.xml, and its root element is <allocations>,
> so conftest raises a false alarm.
> {code}
> [sekikn@mobile hadoop-3.0.0-SNAPSHOT]$ bin/hadoop conftest
> /Users/sekikn/hadoop/hadoop-dist/target/hadoop-3.0.0-SNAPSHOT/etc/hadoop/capacity-scheduler.xml:
> valid
> /Users/sekikn/hadoop/hadoop-dist/target/hadoop-3.0.0-SNAPSHOT/etc/hadoop/core-site.xml:
> valid
> /Users/sekikn/hadoop/hadoop-dist/target/hadoop-3.0.0-SNAPSHOT/etc/hadoop/fair-scheduler.xml:
> bad conf file: top-level element not <configuration>
> /Users/sekikn/hadoop/hadoop-dist/target/hadoop-3.0.0-SNAPSHOT/etc/hadoop/hadoop-policy.xml:
> valid
> /Users/sekikn/hadoop/hadoop-dist/target/hadoop-3.0.0-SNAPSHOT/etc/hadoop/hdfs-site.xml:
> valid
> /Users/sekikn/hadoop/hadoop-dist/target/hadoop-3.0.0-SNAPSHOT/etc/hadoop/httpfs-site.xml:
> valid
> /Users/sekikn/hadoop/hadoop-dist/target/hadoop-3.0.0-SNAPSHOT/etc/hadoop/kms-acls.xml:
> valid
> /Users/sekikn/hadoop/hadoop-dist/target/hadoop-3.0.0-SNAPSHOT/etc/hadoop/kms-site.xml:
> valid
> /Users/sekikn/hadoop/hadoop-dist/target/hadoop-3.0.0-SNAPSHOT/etc/hadoop/mapred-site.xml:
> valid
> /Users/sekikn/hadoop/hadoop-dist/target/hadoop-3.0.0-SNAPSHOT/etc/hadoop/yarn-site.xml:
> valid
> Invalid file exists
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
