[
https://issues.apache.org/jira/browse/HADOOP-11984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14566172#comment-14566172
]
Allen Wittenauer edited comment on HADOOP-11984 at 5/30/15 8:13 PM:
--------------------------------------------------------------------
1. Minor nit:
{code}
(default defined in Hadoop build)
{code}
s,Hadoop,$\{PROJECT_NAME\},g
2. I'm confused as to what the intent here is:
{code}
+ echo "--test-threads=<int> Number of tests to run in parallel (default
defined in Hadoop build)"
{code}
OK, --test-threads takes an int.
{code}
+ --test-threads=*)
+ TEST_THREADS=${i#*=}
+ ;;
{code}
Mhmm ok.
{code}
+ if [[ ${TEST_PARALLEL} == "true" ]] ; then
+ PARALLEL_TESTS_PROFILE=-Pparallel-tests
+ if [[ -z ${TEST_THREADS:-} ]]; then
+ TESTS_THREAD_COUNT=$TEST_THREADS
+ fi
+ fi
{code}
OK, so we've got a count var we're probably going to finish setting up later.
{code}
+ echo_and_redirect "${test_logfile}" "${MVN}" "${MAVEN_ARGS[@]}" clean
install -fae ${NATIVE_PROFILE} ${REQUIRE_TEST_LIB_HADOOP}
${PARALLEL_TESTS_PROFILE} ${TESTS_THREAD_COUNT}
{code}
... umm, the number is now naked on the maven command line.
If I had to guess, you intended for TESTS_THREAD_COUNT="-Dblah=TEST_COUNT"
rather than be a number down here on the maven command line.
was (Author: aw):
1. Minor nit:
{code}
(default defined in Hadoop build)
{code}
s,Hadoop,${PROJECT_NAME},g
2. I'm confused as to what the intent here is:
{code}
+ echo "--test-threads=<int> Number of tests to run in parallel (default
defined in Hadoop build)"
{code}
OK, --test-threads takes an int.
{code}
+ --test-threads=*)
+ TEST_THREADS=${i#*=}
+ ;;
{code}
Mhmm ok.
{code}
+ if [[ ${TEST_PARALLEL} == "true" ]] ; then
+ PARALLEL_TESTS_PROFILE=-Pparallel-tests
+ if [[ -z ${TEST_THREADS:-} ]]; then
+ TESTS_THREAD_COUNT=$TEST_THREADS
+ fi
+ fi
{code}
OK, so we've got a count var we're probably going to finish setting up later.
{code}
+ echo_and_redirect "${test_logfile}" "${MVN}" "${MAVEN_ARGS[@]}" clean
install -fae ${NATIVE_PROFILE} ${REQUIRE_TEST_LIB_HADOOP}
${PARALLEL_TESTS_PROFILE} ${TESTS_THREAD_COUNT}
{code}
... umm, the number is now naked on the maven command line.
If I had to guess, you intended for TESTS_THREAD_COUNT="-Dblah=TEST_COUNT"
rather than be a number down here on the maven command line.
> Enable parallel JUnit tests in pre-commit.
> ------------------------------------------
>
> Key: HADOOP-11984
> URL: https://issues.apache.org/jira/browse/HADOOP-11984
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build, scripts, test
> Reporter: Chris Nauroth
> Assignee: Chris Nauroth
> Attachments: HADOOP-11984.001.patch, HADOOP-11984.002.patch,
> HADOOP-11984.003.patch, HADOOP-11984.004.patch, HADOOP-11984.005.patch,
> HADOOP-11984.006.patch, HADOOP-11984.007.patch, HADOOP-11984.008.patch,
> HADOOP-11984.009.patch, HADOOP-11984.010.patch, HADOOP-11984.011.patch,
> HADOOP-11984.013.patch, HADOOP-11984.014.patch, HADOOP-11984.015.patch,
> HADOOP-11984.016.patch
>
>
> HADOOP-9287 and related issues implemented the parallel-tests Maven profile
> for running JUnit tests in multiple concurrent processes. This issue
> proposes to activate that profile during pre-commit to speed up execution.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
