[ 
https://issues.apache.org/jira/browse/HADOOP-12031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kengo Seki updated HADOOP-12031:
--------------------------------
    Attachment: HADOOP-12031.005.patch

I made a mistake. jrunscript is still shipped with Java8 (though the internal 
engine is replaced with Nashorn), so version detection is unnecessary.

-05:

* always use jrunscript to simplify the code
* pre-check for the executable's existence
* tested on both Java 7 and 8 

I think it's ready for commit.

> test-patch.sh should have an xml plugin
> ---------------------------------------
>
>                 Key: HADOOP-12031
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12031
>             Project: Hadoop Common
>          Issue Type: Test
>          Components: build
>            Reporter: Allen Wittenauer
>            Assignee: Kengo Seki
>              Labels: newbie, test-patch
>         Attachments: HADOOP-12031.001.patch, HADOOP-12031.002.patch, 
> HADOOP-12031.003.patch, HADOOP-12031.004.patch, HADOOP-12031.005.patch
>
>
> HADOOP-11178 demonstrates why there is a need to verify xml files on a patch 
> change.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to