[ 
https://issues.apache.org/jira/browse/HADOOP-12031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14560521#comment-14560521
 ] 

Kengo Seki commented on HADOOP-12031:
-------------------------------------

Thanks [~busbey]. As you pointed out, I realized that 002.patch does not work 
on Python 2.6-, because except ... as ... statement is supported from 2.6.1.
So I'm planning:

* If xmllint is available, use it
* If not, try to validate using Python. In that case, use sys.exc_info() 
instead of except ... as ... statement. It makes the plugin to work on Python 
at least 2.1+ (including 3.x).


> test-patch.sh should have an xml plugin
> ---------------------------------------
>
>                 Key: HADOOP-12031
>                 URL: https://issues.apache.org/jira/browse/HADOOP-12031
>             Project: Hadoop Common
>          Issue Type: Test
>          Components: build
>            Reporter: Allen Wittenauer
>            Assignee: Kengo Seki
>              Labels: newbie, test-patch
>         Attachments: HADOOP-12031.001.patch, HADOOP-12031.002.patch
>
>
> HADOOP-11178 demonstrates why there is a need to verify xml files on a patch 
> change.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to