[
https://issues.apache.org/jira/browse/HADOOP-12028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14558337#comment-14558337
]
Hadoop QA commented on HADOOP-12028:
------------------------------------
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 14m 53s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:red}-1{color} | tests included | 0m 0s | The patch doesn't appear
to include any new or modified tests. Please justify why no new tests are
needed for this patch. Also please list what manual steps were performed to
verify this patch. |
| {color:green}+1{color} | javac | 7m 33s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 9m 35s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 24s | The applied patch does
not increase the total number of release audit warnings. |
| {color:red}-1{color} | checkstyle | 1m 4s | The applied patch generated 1
new checkstyle issues (total was 218, now 218). |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 36s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 40s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 1m 42s | The patch does not introduce
any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | common tests | 23m 8s | Tests passed in
hadoop-common. |
| | | 60m 39s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12735169/HADOOP-12028.1.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / ada233b |
| checkstyle |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6820/artifact/patchprocess/diffcheckstylehadoop-common.txt
|
| hadoop-common test log |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6820/artifact/patchprocess/testrun_hadoop-common.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6820/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HADOOP-Build/6820/console |
This message was automatically generated.
> Allow to set handler thread name when building IPC Server
> ---------------------------------------------------------
>
> Key: HADOOP-12028
> URL: https://issues.apache.org/jira/browse/HADOOP-12028
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 2.7.0
> Reporter: Jeff Zhang
> Priority: Minor
> Attachments: HADOOP-12028.1.patch
>
>
> Currently IPC use the server port to differentiate it with other IPC server.
> This is not very clear especially when port is randomly generated. It is
> better to set the server name when building the server and use the server
> name as the part of handler thread name
> {code}
> 2015-05-25 10:43:40,181 INFO [IPC Server handler 0 on 58849]
> history.HistoryEventHandler
> (HistoryEventHandler.java:handleCriticalEvent(110)) -
> [HISTORY][DAG:dag_1432521818638_0001_1][Event:DAG_SUBMITTED]:
> dagID=dag_1432521818638_0001_1, submitTime=1432521820100
> 2015-05-25 10:43:40,200 INFO [IPC Server handler 0 on 58849] impl.DAGImpl
> (DAGImpl.java:assignDAGScheduler(1360)) - Using DAG Scheduler:
> org.apache.tez.dag.app.dag.impl.DAGSchedulerNaturalOrderControlled
> 2015-05-25 10:43:40,201 INFO [IPC Server handler 0 on 58849] h
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)