[ 
https://issues.apache.org/jira/browse/HADOOP-11807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14547188#comment-14547188
 ] 

Kengo Seki commented on HADOOP-11807:
-------------------------------------

[~ramtinb], sorry for late response and thank you for your work.

* As for my previous comment, the new patch almost looks good to me. Just one 
more comment, would you replace "== None" and "!= None" in the existing code 
with "is None" and "is not None"?
* If there is an error, the new script fails correctly in non-normal mode, but 
partially generated files remain. I think it is better to defer output or clean 
them up.

> add a lint mode to releasedocmaker
> ----------------------------------
>
>                 Key: HADOOP-11807
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11807
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build, documentation
>    Affects Versions: 3.0.0
>            Reporter: Allen Wittenauer
>            Assignee: ramtin
>            Priority: Minor
>         Attachments: HADOOP-11807.001.patch, HADOOP-11807.002.patch, 
> HADOOP-11807.003.patch
>
>
> * check for missing components (error)
> * check for missing assignee (error)
> * check for common version problems (warning)
> * add an error message for missing release notes



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to