[
https://issues.apache.org/jira/browse/HADOOP-11889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gera Shegalov updated HADOOP-11889:
-----------------------------------
Attachment: HADOOP-11889.003.patch
Thanks for reviewing the patch, [~jeagles]!
bq. From a high level I would still like to see the checkstyle.xml file under
the hadoop-build-tools src/main/resources. Perhaps that explains the build
failure below.
That's already the case, see patch:
{code}
rename from hadoop-common-project/hadoop-common/dev-support/checkstyle.xml
rename to hadoop-build-tools/src/main/resources/checkstyle/checkstyle.xml
{code}
bq. can we remove azure maven-checkstyle-plugin definition?
Meant to do this, but they have different rule sets.
{code}
[tw-mbp-gshegalov hadoop-common (HADOOP-11889)]$ diff -u
./hadoop-build-tools/src/main/resources/checkstyle/checkstyle.xml
./hadoop-tools/hadoop-azure/src/config/checkstyle.xml | diffstat
checkstyle.xml | 138 ++++++++++++++++++++++++++++-----------------------------
1 file changed, 69 insertions(+), 69 deletions(-)
{code}
bq. the mvn checkstyle:checkstyle goal fails to the checkstyle/checkstyle.xml
file being in the incorrect location
the location is correct. I forgot to remove {{RedundantThrows}} (not supported
since 6.2) from azure's checkstyle.xml the same way I dropped it from the main
one.
bq. Looks like a few typos
fixed
bq. This is the first reference to dependency of hadoop artifact by version. I
think we are safe without this.
fixed
Please review 003 patch.
> Make checkstyle runnable from root project
> ------------------------------------------
>
> Key: HADOOP-11889
> URL: https://issues.apache.org/jira/browse/HADOOP-11889
> Project: Hadoop Common
> Issue Type: Bug
> Components: build, test
> Affects Versions: 2.7.0
> Reporter: Gera Shegalov
> Assignee: Gera Shegalov
> Attachments: HADOOP-11889.001.patch, HADOOP-11889.002.patch,
> HADOOP-11889.003.patch
>
>
> Checkstyle -1 are hard to debug without submitting to Jenkins and downloading
> build artifacts.
> With this JIRA we
> # remove identical checkstyle rules in hdfs which is identical to common
> # move checkstyle plugin to the parent pom
> # update rules to ignore import
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
