[
https://issues.apache.org/jira/browse/HADOOP-11746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14505598#comment-14505598
]
Chris Nauroth commented on HADOOP-11746:
----------------------------------------
I checked the diff since my last review (-17), and everything looks good to me.
I agree with the decision to maintain the existing behavior of -1 when the
existing trunk build is already broken, and I agree with changing those failure
code paths to exit with a non-zero code.
+1 for patch -21. Thanks for your work on this, Allen. The new functionality
is great. Now hurry up and commit before you get more ideas! :-) Sean, thank
you for helping with the code review.
> rewrite test-patch.sh
> ---------------------
>
> Key: HADOOP-11746
> URL: https://issues.apache.org/jira/browse/HADOOP-11746
> Project: Hadoop Common
> Issue Type: Test
> Components: build, test
> Affects Versions: 3.0.0
> Reporter: Allen Wittenauer
> Assignee: Allen Wittenauer
> Attachments: HADOOP-11746-00.patch, HADOOP-11746-01.patch,
> HADOOP-11746-02.patch, HADOOP-11746-03.patch, HADOOP-11746-04.patch,
> HADOOP-11746-05.patch, HADOOP-11746-06.patch, HADOOP-11746-07.patch,
> HADOOP-11746-09.patch, HADOOP-11746-10.patch, HADOOP-11746-11.patch,
> HADOOP-11746-12.patch, HADOOP-11746-13.patch, HADOOP-11746-14.patch,
> HADOOP-11746-15.patch, HADOOP-11746-16.patch, HADOOP-11746-17.patch,
> HADOOP-11746-18.patch, HADOOP-11746-19.patch, HADOOP-11746-20.patch,
> HADOOP-11746-21.patch
>
>
> This code is bad and you should feel bad.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
