[jira] [Commented] (HADOOP-11627) Remove io.native.lib.available from trunk

[Akira AJISAKA (JIRA)]

    [ 
https://issues.apache.org/jira/browse/HADOOP-11627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14497897#comment-14497897
 ] 

Akira AJISAKA commented on HADOOP-11627:
----------------------------------------

Thanks [~brahmareddy] for updating the patch.
{code}
  @Test
  public void testGzipCodecWriteJava() throws IOException {
    testGzipCodecWrite(false);
  }

  @Test
  public void testGzipNativeCodecWrite() throws IOException {
    // don't use native libs
    ZlibFactory.setNativeZlibLoaded(false);
    testGzipCodecWrite(true);
  }
{code}
Would you move {{ZlibFactory.setNativeZlibLoaded(false)}} into 
{{testGzipCodecWriteJava()}}? I'm thinking that fixes the test failure. 
(https://builds.apache.org/job/PreCommit-HADOOP-Build/6062//testReport/org.apache.hadoop.io.compress/TestCodec/testGzipCodecWriteJava/)

> Remove io.native.lib.available from trunk
> -----------------------------------------
>
>                 Key: HADOOP-11627
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11627
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 3.0.0
>            Reporter: Akira AJISAKA
>            Assignee: Brahma Reddy Battula
>         Attachments: HADOOP-11627-002.patch, HADOOP-11627-003.patch, 
> HADOOP-11627-004.patch, HADOOP-11627-005.patch, HADOOP-11627-006.patch, 
> HADOOP-11627-007.patch, HADOOP-11627.patch
>
>
> According to the discussion in HADOOP-8642, we should remove 
> {{io.native.lib.available}} from trunk, and always use native libraries if 
> they exist.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)