[
https://issues.apache.org/jira/browse/HADOOP-11746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14385629#comment-14385629
]
Allen Wittenauer commented on HADOOP-11746:
-------------------------------------------
Current shell-output:
{noformat}
-1 overall
| Vote | Subsystem | Runtime | Comment
| 0 | pre-patch | 09m 30s | Pre-patch HADOOP-11746 compilation
| | | | is healthy.
| +1 | @author | 00m 00s | The patch does not contain any
| | | | @author tags.
| -1 | tests included | 00m 00s | The patch doesn't appear to include
| | | | any new or modified tests. Please
| | | | justify why no new tests are needed
| | | | for this patch. Also please list what
| | | | manual steps were performed to verify
| | | | this patch.
| +1 | javac | 04m 22s | There were no new javac warning
| | | | messages.
| +1 | javadoc | 06m 16s | There were no new javadoc warning
| | | | messages.
| -1 | release audit | 00m 09s | The applied patch generated 3
| | | | release audit warnings.
| +1 | checkstyle | 03m 04s | There were no new checkstyle
issues.
| +1 | shellcheck | 00m 02s | There were no new shellcheck
issues.
| +1 | install | 02m 31s | mvn install still works.
| +1 | eclipse:eclipse | 00m 24s | The patch built with
| | | | eclipse:eclipse.
|| Subsystem || Report ||
| Release Audit | /tmp/hadoop-test-patch/14934/patchReleaseAuditProblems.txt |
{noformat}
The current jira format has some minor issues. :( Fixing the two missing new
lines and the missing backslash results in:
(x) *{color:red}-1 overall{color}*
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 09m 30s | Pre-patch HADOOP-11746
compilation is healthy. |
| {color:green}+1{color} | @author | 00m 00s | The patch does not contain any
@author tags. |
| {color:red}-1{color} | tests included | 00m 00s | The patch doesn't appear to
include any new or modified tests. Please justify why no new tests are needed
for this patch. Also please list what manual steps were performed to verify
this patch. |
| {color:green}+1{color} | javac | 04m 22s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 06m 16s | There were no new javadoc
warning messages. |
| {color:red}-1{color} | release audit | 00m 09s | The applied patch generated
3 release audit warnings. |
| {color:green}+1{color} | checkstyle | 03m 04s | There were no new checkstyle
issues. |
| {color:green}+1{color} | shellcheck | 00m 02s | There were no new shellcheck
issues. |
| {color:green}+1{color} | install | 02m 31s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 00m 24s | The patch built with
eclipse:eclipse. |
\\
|| Subsystem || Report ||
| Release Audit | /artifact/patchprocess/patchReleaseAuditProblems.txt |
| Console output | /artifact/patchprocess/console |
This message was automatically generated.
> rewrite test-patch.sh
> ---------------------
>
> Key: HADOOP-11746
> URL: https://issues.apache.org/jira/browse/HADOOP-11746
> Project: Hadoop Common
> Issue Type: Test
> Components: build, test
> Affects Versions: 3.0.0
> Reporter: Allen Wittenauer
> Assignee: Allen Wittenauer
> Attachments: HADOOP-11746-00.patch, HADOOP-11746-01.patch,
> HADOOP-11746-02.patch, HADOOP-11746-03.patch
>
>
> This code is bad and you should feel bad.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
