[ 
https://issues.apache.org/jira/browse/HADOOP-11748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14383033#comment-14383033
 ] 

Hadoop QA commented on HADOOP-11748:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12707639/HADOOP-11748.001.patch
  against trunk revision 5695c7a.

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 4 new 
or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

    {color:red}-1 findbugs{color}.  The patch appears to introduce 2 new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-common-project/hadoop-auth hadoop-hdfs-project/hadoop-hdfs-httpfs.

Test results: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/6006//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/6006//artifact/patchprocess/newPatchFindbugsWarningshadoop-auth.html
Console output: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/6006//console

This message is automatically generated.

> Secrets for auth cookies can be specified in clear text
> -------------------------------------------------------
>
>                 Key: HADOOP-11748
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11748
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Haohui Mai
>            Assignee: Li Lu
>            Priority: Critical
>         Attachments: HADOOP-11748-032615-poc.patch, HADOOP-11748.001.patch
>
>
> Based on the discussion on HADOOP-10670, this jira proposes to remove 
> {{StringSecretProvider}} as it opens up possibilities for misconfiguration 
> and security vulnerabilities.
> {quote}
> My understanding is that the use case of inlining the secret is never 
> supported. The property is used to pass the secret internally. The way it 
> works before HADOOP-10868 is the following:
> * Users specify the initializer of the authentication filter in the 
> configuration.
> * AuthenticationFilterInitializer reads the secret file. The server will not 
> start if the secret file does not exists. The initializer will set the 
> property if it read the file correctly.
> *There is no way to specify the secret in the configuration out-of-the-box – 
> the secret is always overwritten by AuthenticationFilterInitializer.
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to