[jira] [Commented] (HADOOP-11627) Remove io.native.lib.available from trunk

[Akira AJISAKA (JIRA)]

    [ 
https://issues.apache.org/jira/browse/HADOOP-11627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14356892#comment-14356892
 ] 

Akira AJISAKA commented on HADOOP-11627:
----------------------------------------

Thanks [~brahmareddy] for rebasing. Some comments:
1. Would you remove the following code from TestTFileSeqFileComparison.java?
{code}
      conf.setBoolean(CommonConfigurationKeys.IO_NATIVE_LIB_AVAILABLE_KEY,
                      true);
{code}
2. Some tests fail in TestCodec.java when {{-Pnative}} is specified.
{code}
Failed tests: 
  TestCodec.testGzipCompatibility:661 expected:<class 
org.apache.hadoop.io.compress.zlib.BuiltInGzipDecompressor> but was:<class 
org.apache.hadoop.io.compress.GzipCodec$GzipZlibDecompressor>
  TestCodec.testGzipCodecWriteJava:879->testGzipCodecWrite:829 ZlibFactory is 
using native libs against request
  TestCodec.testGzipLongOverflow:778 ZlibFactory is using native libs against 
request
  TestCodec.testGzipCodecRead:727 ZlibFactory is using native libs against 
request
  TestCodec.testBuiltInGzipConcat:710->GzipConcatTest:696 expected:<class 
org.apache.hadoop.io.compress.zlib.BuiltInGzipDecompressor> but was:<class 
org.apache.hadoop.io.compress.GzipCodec$GzipZlibDecompressor>

Tests run: 24, Failures: 5, Errors: 0, Skipped: 1
{code}
I'm thinking we can fix these failures by adding a setter method for 
{{ZlibFactory.nativeZlibLoaded}} and setting the variable to false instead of 
just removing 
{{conf.setBoolean(CommonConfigurationKeys.IO_NATIVE_LIB_AVAILABLE_KEY, 
false)}}. If we use the setter method, we should add {{@After}} method in the 
test to reset the variable.

> Remove io.native.lib.available from trunk
> -----------------------------------------
>
>                 Key: HADOOP-11627
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11627
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 3.0.0
>            Reporter: Akira AJISAKA
>            Assignee: Brahma Reddy Battula
>         Attachments: HADOOP-11627-002.patch, HADOOP-11627-003.patch, 
> HADOOP-11627-004.patch, HADOOP-11627-005.patch, HADOOP-11627.patch
>
>
> According to the discussion in HADOOP-8642, we should remove 
> {{io.native.lib.available}} from trunk, and always use native libraries if 
> they exist.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)