[
https://issues.apache.org/jira/browse/HADOOP-7947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14352382#comment-14352382
]
Allen Wittenauer commented on HADOOP-7947:
------------------------------------------
Playing around with this, it mostly worked as expected. It's very cool to have
the feature!
I do have a few nits though:
{code}
$ bin/hadoop conftest --help
OK
$ bin/hadoop conftest -h
OK
$ bin/hadoop conftest -help
OK
{code}
Help, how do I get help?
{code}
$ bin/hadoop conftest -conf ~/HADOOP/conf2/
/Users/aw/HADOOP/conf2 is not a file
{code}
Oh, so -conf doesn't work like the rest of Hadoop. :( I really want to pass it
a complete directory so that I can do things like:
{code}
hadoop conftest --conf newconf
if [[ $? =0 ]]; then
sbin/stop-dfs.sh
mv conf oldconf.$$
mv newconf conf
sbin/start-dfs.sh
else
echo "Yo, your config don't work!"
exit 1
fi
{code}
I really feel as though it should probably just call GenericOptionsParser
straight up rather than emulate it. This way it will also pick up any other
features that it has or gets added in the future.
Awesome work so far though! Really looking forward to this one!
> Validate XMLs if a relevant tool is available, when using scripts
> -----------------------------------------------------------------
>
> Key: HADOOP-7947
> URL: https://issues.apache.org/jira/browse/HADOOP-7947
> Project: Hadoop Common
> Issue Type: Wish
> Components: scripts
> Affects Versions: 2.7.0
> Reporter: Harsh J
> Assignee: Kengo Seki
> Labels: newbie
> Attachments: HADOOP-7947.001.patch, HADOOP-7947.002.patch,
> HADOOP-7947.003.patch
>
>
> Given that we are locked down to using only XML for configuration and most of
> the administrators need to manage it by themselves (unless a tool that
> manages for you is used), it would be good to also validate the provided
> config XML (*-site.xml) files with a tool like {{xmllint}} or maybe Xerces
> somehow, when running a command or (at least) when starting up daemons.
> We should use this only if a relevant tool is available, and optionally be
> silent if the env. requests.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
