[
https://issues.apache.org/jira/browse/HADOOP-11660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14350788#comment-14350788
]
Colin Patrick McCabe commented on HADOOP-11660:
-----------------------------------------------
Thanks for working on this, [~enevill]. I think the #ifdefs are getting kind
of out of control in this file. This isn't really your fault... it's a mess
even now. But adding another dimension of #ifdefing just makes my brain hurt.
How about we split the hardware-specific code for x86 into
{{bulk_crc32_x86.c}}, and the ARM-specific code off into
{{bulk_crc32_aarch64.c}}. CMake will compile in the relevant file based on the
architecture. I would say both of the platform specific files should implement
the same functions, so that the generic part can be compiled against either.
I suppose we'd still have the USE_PIPELINED ifdefs, but one dimension of ifdefs
is possible to understand (for me, at least).
Do you think that's possible?
> Add support for hardware crc on ARM aarch64 architecture
> --------------------------------------------------------
>
> Key: HADOOP-11660
> URL: https://issues.apache.org/jira/browse/HADOOP-11660
> Project: Hadoop Common
> Issue Type: Improvement
> Components: native
> Affects Versions: 3.0.0
> Environment: ARM aarch64 development platform
> Reporter: Edward Nevill
> Assignee: Edward Nevill
> Priority: Minor
> Labels: performance
> Attachments: jira-11660.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> This patch adds support for hardware crc for ARM's new 64 bit architecture
> The patch is completely conditionalized on __aarch64__
> I have only added support for the non pipelined version as I benchmarked the
> pipelined version on aarch64 and it showed no performance improvement.
> The aarch64 version supports both Castagnoli and Zlib CRCs as both of these
> are supported on ARM aarch64 hardwre.
> To benchmark this I modified the test_bulk_crc32 test to print out the time
> taken to CRC a 1MB dataset 1000 times.
> Before:
> CRC 1048576 bytes @ 512 bytes per checksum X 1000 iterations = 2.55
> CRC 1048576 bytes @ 512 bytes per checksum X 1000 iterations = 2.55
> After:
> CRC 1048576 bytes @ 512 bytes per checksum X 1000 iterations = 0.57
> CRC 1048576 bytes @ 512 bytes per checksum X 1000 iterations = 0.57
> So this represents a 5X performance improvement on raw CRC calculation.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
