[
https://issues.apache.org/jira/browse/HADOOP-11565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14317670#comment-14317670
]
Chris Nauroth commented on HADOOP-11565:
----------------------------------------
Thanks for the patch, Allen. This looks good to me. I took it for a test run,
and it worked as expected. Just a few minor nitpicks:
# Both hadoop-daemons.sh and yarn-daemons.sh have 2 spaces between --slaves and
--daemon in the translated command. Let's make it one space.
# In yarn-daemons.sh, the deprecation warning message says that it's attempting
to execute "YARN" (all caps). Let's make it "yarn".
Regarding naming, --slaves-file makes me think the next argument is intended to
be the path to the slaves file. I like something more generic like --batch,
but even running --daemon without this extra option is still a batch
(non-interactive) invocation, so that's not entirely accurate. What about
something like --cluster to indicate the operation is fanning out to all nodes
in the cluster? If not that, then I still think --slaves is the best choice,
though I don't feel strongly about this.
> Add --slaves shell option
> -------------------------
>
> Key: HADOOP-11565
> URL: https://issues.apache.org/jira/browse/HADOOP-11565
> Project: Hadoop Common
> Issue Type: New Feature
> Components: scripts
> Reporter: Allen Wittenauer
> Attachments: HADOOP-11565-00.patch
>
>
> Add a --slaves shell option to hadoop-config.sh to trigger the given command
> on slave nodes. This is required to deprecate hadoop-daemons.sh and
> yarn-daemons.sh.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
