[
https://issues.apache.org/jira/browse/HADOOP-10392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14287382#comment-14287382
]
Steve Loughran commented on HADOOP-10392:
-----------------------------------------
Quite a fiew of the MR tests go {{System.getProperty("test.build.data",
"/tmp"))) ... they should fall back to something cross platform, maybe just
"target" or the system tmp dir property. Even though this is on the same line
as these patches, I think it's something to keep separate to reduce the delta
of this patch
What I would recommend, though is that in {{TestHistograms}} the call
{{System.getProperty("test.tools.input.dir", "")}} is hardened to something
like {{System.getProperty("test.tools.input.dir", "target/input")}} to give it
some kind of fallback on an IDE-run that doesn't set the system properties
right.
Otherwise I'm happy with it. Let's see what happens against trunk now
> Use FileSystem#makeQualified(Path) instead of Path#makeQualified(FileSystem)
> ----------------------------------------------------------------------------
>
> Key: HADOOP-10392
> URL: https://issues.apache.org/jira/browse/HADOOP-10392
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs
> Affects Versions: 2.3.0
> Reporter: Akira AJISAKA
> Assignee: Akira AJISAKA
> Priority: Minor
> Labels: newbie
> Attachments: HADOOP-10392.2.patch, HADOOP-10392.3.patch,
> HADOOP-10392.4.patch, HADOOP-10392.4.patch, HADOOP-10392.5.patch,
> HADOOP-10392.6.patch, HADOOP-10392.patch
>
>
> There're some methods calling Path.makeQualified(FileSystem), which causes
> javac warning.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
