[
https://issues.apache.org/jira/browse/HADOOP-11171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Demoor updated HADOOP-11171:
-----------------------------------
Attachment: HADOOP-11171-8.patch
Patch 8 addresses Steve's 3 remarks.
bq. p140: what if a field like password or domain is not supplied. Is setting
them to null acceptable? I presume so, based on the testsl
In the aws-sdk, they all default to null
(com/amazonaws/ClientConfiguration.java) and are used as follows:
{code:title=com/amazonaws/http/HttpClientFactory.java}
if (proxyUsername != null && proxyPassword != null) {
httpClient.getCredentialsProvider().setCredentials(
new AuthScope(proxyHost, proxyPort),
new NTCredentials(proxyUsername, proxyPassword,
proxyWorkstation,proxyDomain));
}
{code}
Further investigation of NTCredentials and NTUserPrincipal reveal that
workstation and domain are allowed to be null.
However, if username or password is set while the other is null the aws-sdk
skips this code block. This patch adds code to throw an exception in this case
(+ testcase).
> Enable using a proxy server to connect to S3a.
> ----------------------------------------------
>
> Key: HADOOP-11171
> URL: https://issues.apache.org/jira/browse/HADOOP-11171
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs/s3
> Affects Versions: 2.4.0
> Reporter: Thomas Demoor
> Assignee: Thomas Demoor
> Labels: amazon, s3
> Attachments: HADOOP-11171-2.patch, HADOOP-11171-3.patch,
> HADOOP-11171-4.patch, HADOOP-11171-5.patch, HADOOP-11171-6.patch,
> HADOOP-11171-7.patch, HADOOP-11171-8.patch, HADOOP-11171.patch
>
>
> This exposes the AWS SDK config for a proxy (host and port) to s3a through
> config settings.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
