[
https://issues.apache.org/jira/browse/HADOOP-11349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14240092#comment-14240092
]
Hadoop QA commented on HADOOP-11349:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12686088/HADOOP-11349.004.patch
against trunk revision 5776a41.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:red}-1 findbugs{color}. The patch appears to introduce 111 new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-common-project/hadoop-common:
org.apache.hadoop.ha.TestSshFenceByTcpPort
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5213//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5213//artifact/patchprocess/newPatchFindbugsWarningshadoop-common.html
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5213//console
This message is automatically generated.
> RawLocalFileSystem leaks file descriptor while creating a file if creat
> succeeds but chmod fails.
> -------------------------------------------------------------------------------------------------
>
> Key: HADOOP-11349
> URL: https://issues.apache.org/jira/browse/HADOOP-11349
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 2.6.0
> Reporter: Chris Nauroth
> Assignee: Varun Saxena
> Priority: Minor
> Fix For: 2.7.0
>
> Attachments: HADOOP-11349.002.patch, HADOOP-11349.003.patch,
> HADOOP-11349.004.patch, HADOOP-11349.005.patch, HADOOP-11349.patch
>
>
> {{RawLocalFileSystem}} currently implements some file creation operations as
> a sequence of 2 syscalls: create the file, followed by setting its
> permissions. If creation succeeds, but then setting permission causes an
> exception to be thrown, then there is no attempt to close the previously
> opened file, resulting in a file descriptor leak.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)