[
https://issues.apache.org/jira/browse/HADOOP-10926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14222840#comment-14222840
]
Steve Loughran commented on HADOOP-10926:
-----------------------------------------
looks OK to me, though needs someone with more bash skills to review it.
IF this goes in, are there some test JIRAs which can be submitted to test all
the various cases?
> Improve smart-apply-patch.sh to apply binary diffs
> --------------------------------------------------
>
> Key: HADOOP-10926
> URL: https://issues.apache.org/jira/browse/HADOOP-10926
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 3.0.0
> Reporter: Andrew Wang
> Assignee: Colin Patrick McCabe
> Attachments: HADOOP-10926.001.patch, HADOOP-10926.002.patch,
> HADOOP-10926.003.patch, HADOOP-10926.004.patch
>
>
> The Unix {{patch}} command cannot apply binary diffs as generated via {{git
> diff --binary}}. This means we cannot get effective test-patch.sh runs when
> the patch requires adding a binary file.
> We should consider using a different patch method.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
