[ 
https://issues.apache.org/jira/browse/HADOOP-11313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14217004#comment-14217004
 ] 

Chris Nauroth commented on HADOOP-11313:
----------------------------------------

Hi, Tsuyoshi.  This is a good idea.  Thank you for posting a patch.  I have a 
few recommendations:
# Instead of running it through {{hadoop jar}} with the full class name, the 
shorter way to run this command is {{hadoop checknative}}.  I recommend using 
the shorter form in the documentation.
# Related to the above, since it's part of our CLI, I recommend adding 
documentation to CommandsManual.apt.vm too.  Let's include mention of the 
{{-a}} option.  Without {{-a}}, the command only checks for 
libhadoop.so/hadoop.dll.  With {{-a}}, the command checks for all the libraries 
that hadoop-common dynamically links to.
# I think it would be more informative for the sample here to show what the 
output looks like when the native code is found.  In particular, it displays 
the absolute path to each library it finds, which can be very helpful.  Here is 
a sample from one of my dev environments:
{code}
[cnauroth@ubuntu:pts/2] hadoop-2.5.2                                            
                                    
> hadoop checknative
Native library checking:
hadoop: true /home/cnauroth/hadoop-2.5.2/lib/native/libhadoop.so.1.0.0
zlib:   true /lib/x86_64-linux-gnu/libz.so.1
snappy: true /usr/local/lib/libsnappy.so.1
lz4:    true revision:99
bzip2:  false 
{code}



> Adding a document about NativeLibraryChecker
> --------------------------------------------
>
>                 Key: HADOOP-11313
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11313
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: documentation
>    Affects Versions: 2.7.0
>            Reporter: Tsuyoshi OZAWA
>            Assignee: Tsuyoshi OZAWA
>         Attachments: HADOOP-11313.1.patch
>
>
> NativeLibraryChecker is a good tool to check whether native libraries are 
> loaded correctly. We don't have any docs about this, so we should add it to 
> NativeLibraries.apt.vm.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to