[
https://issues.apache.org/jira/browse/HADOOP-10895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14200489#comment-14200489
]
Alejandro Abdelnur commented on HADOOP-10895:
---------------------------------------------
The name of the properties and methods {{allowFallbackToPseudoAuth}} and
{{allowDefaultAuthToFallbackToPseudo}} is a bit odd, I would have 'Default' at
the end.
In the {{KMSClientProvider}}, instead setting the default fallback, we should
create the authenticator with the on/off setting and pass it to the
authenticated URL. You don't want a global setting as some other place in the
code could change the default and it will unknowingly impact the
{{KMSCLientProvider}}. This should be the rule for all places where
{{AuthenticatedURL}} is used.
Other than that, the patch seem OK.
Thx
> HTTP KerberosAuthenticator fallback should have a flag to disable it
> --------------------------------------------------------------------
>
> Key: HADOOP-10895
> URL: https://issues.apache.org/jira/browse/HADOOP-10895
> Project: Hadoop Common
> Issue Type: Bug
> Components: security
> Affects Versions: 2.4.1
> Reporter: Alejandro Abdelnur
> Assignee: Yongjun Zhang
> Priority: Blocker
> Attachments: HADOOP-10895.001.patch, HADOOP-10895.002.patch,
> HADOOP-10895.003.patch, HADOOP-10895.003v1.patch, HADOOP-10895.003v2.patch,
> HADOOP-10895.003v2improved.patch, HADOOP-10895.004.patch,
> HADOOP-10895.005.patch, HADOOP-10895.006.patch, HADOOP-10895.007.patch
>
>
> Per review feedback in HADOOP-10771, {{KerberosAuthenticator}} and the
> delegation token version coming in with HADOOP-10771 should have a flag to
> disable fallback to pseudo, similarly to the one that was introduced in
> Hadoop RPC client with HADOOP-9698.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
