[ 
https://issues.apache.org/jira/browse/HADOOP-11157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14191185#comment-14191185
 ] 

Arun Suresh commented on HADOOP-11157:
--------------------------------------

bq. Here, and in the opposite case where stat == null on the add/remove, don't 
we want to handle those case
No, in the event the node receives an Add / Update event, it checks ZK.. it 
stores in local cache ONLY if (stat != null).. it (stat == null) it should not 
do anything, since the node might have been removed by another ZKDTSM. As per 
the Log message.. I agree i can change it.. I am also considering throwing the 
{{IOException}} and bailing out if it can't reach ZK.

bq. We aren't guaranteed to see every notification 
(http://zookeeper.apache.org/doc/trunk/zookeeperProgrammers.html#ch_zkWatches)
I am using Curator PathCache.. which as per the documentation and some 
discussion sez it receives all events eventually : 
https://groups.google.com/forum/#!msg/curator-users/mGkG8w6PG9w/zv8jkiEEE78J

bq. It would be nice if there were a test for starting a secret manager after a 
delegation token on another secret manager has already been 
sure.. will add some more tests..



> ZKDelegationTokenSecretManager never shuts down listenerThreadPool
> ------------------------------------------------------------------
>
>                 Key: HADOOP-11157
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11157
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: security
>    Affects Versions: 2.6.0
>            Reporter: Gregory Chanan
>            Assignee: Arun Suresh
>         Attachments: HADOOP-11157.2.patch, HADOOP-11157.patch, 
> HADOOP-11157.patch
>
>
> I'm trying to integrate Solr with the DelegationTokenAuthenticationFilter and 
> running into this issue.  The solr unit tests look for leaked threads and 
> when I started using the ZKDelegationTokenSecretManager it started reporting 
> leaks.  Shuting down the listenerThreadPool after the objects that use it 
> resolves the leak threads errors.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to