[
https://issues.apache.org/jira/browse/HADOOP-11161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14164496#comment-14164496
]
Aaron T. Myers commented on HADOOP-11161:
-----------------------------------------
+1, the latest patch looks good to me. Writing a test to exercise this leak
would be quite difficult, and I'm confident that the release audit and test
failure are unrelated. The tests fails locally for me without the patch, and
the RAT warning has been showing up in other builds as well and I believe is
referencing a file unrelated to this patch.
I'm going to commit this momentarily.
> Expose close method in KeyProvider to give clients of Provider
> implementations a hook to release resources
> ----------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-11161
> URL: https://issues.apache.org/jira/browse/HADOOP-11161
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Arun Suresh
> Assignee: Arun Suresh
> Attachments: HADOOP-11161.1.patch, HADOOP-11161.2.patch,
> HADOOP-11161.3.patch
>
>
> The {{KMSClientProvider}} class needs to be have a {{close()}} method to
> shutdown back ground executor threads.
> The {{DFSClient}} creates an instance of a {{KeyProvider}} during
> initialization. If this KP is a {{KMSClientProvider}}, this needs to be
> closed to prevent thread leakage
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
