[
https://issues.apache.org/jira/browse/HADOOP-11081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14137891#comment-14137891
]
Sean Busbey commented on HADOOP-11081:
--------------------------------------
{noformat}
+# and clients (i.e., hdfs dfs -blah). These get appended to HADOOP_OPTS for
+# such commands. In most cases, # this should be left empty and
+# let users supply it on the command line.
{noformat}
nit: extra '#' mid-line.
{noformat}
+#
+# NOTE: this is not used by default! <-----
+# You can define variables right here and then re-use them later on.
+# For example, it is common to use the same garbage collection settings
+# for all the daemons. So one could define:
+#
+# export HADOOP_GC_SETTINGS="-verbose:gc -XX:+PrintGCDetails
-XX:+PrintGCTimeStamps -XX:+PrintGCDateStamps"
+#
+# .. and then use it as per the b option under the namenode.
+
{noformat}
What does "this" refer to here? HADOOP_GC_SETTINGS? or just the practice of
defining variables and reusing them?
{noformat}
HADOOP_HDFS_IDENT_STRING="${HADOOP_IDENT_STRING}"
+
# turn on the defaults
{noformat}
nit: extra blank line
> Document hadoop properties expected to be set by the shell code in *-env.sh
> ---------------------------------------------------------------------------
>
> Key: HADOOP-11081
> URL: https://issues.apache.org/jira/browse/HADOOP-11081
> Project: Hadoop Common
> Issue Type: Improvement
> Components: documentation, scripts
> Reporter: Allen Wittenauer
> Assignee: Allen Wittenauer
> Labels: newbie
> Attachments: HADOOP-11081-01.patch, HADOOP-11081-02.patch,
> HADOOP-11081.patch
>
>
> There are quite a few Java properties that are expected to be set by the
> shell code. These are currently undocumented.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
