[
https://issues.apache.org/jira/browse/HADOOP-11042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14118046#comment-14118046
]
Hadoop QA commented on HADOOP-11042:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12665868/HADOOP-11042.001.patch
against trunk revision 258c7d0.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 17 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.server.datanode.TestCachingStrategy
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/4626//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/4626//console
This message is automatically generated.
> CryptoInputStream throwing wrong exception class on errors
> ----------------------------------------------------------
>
> Key: HADOOP-11042
> URL: https://issues.apache.org/jira/browse/HADOOP-11042
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Reporter: Steve Loughran
> Assignee: Yi Liu
> Attachments: HADOOP-11042.001.patch
>
>
> Having had a quick look at the {{CryptoInputStream}} class, it's not in sync
> with all the other filesystem's exception logic, as specified in
> {{src/site/markdown/filesystem/fsdatainputstream.md}}
> Operations MUST throw an {{IOException}} on out of bounds reads, ideally
> {{EOFException}} :
> # {{read(byte[] b, int off, int len)}}
> # {{seek(long pos) }}
> # {{seekToNewSource}}
> The tests you want to extend to verify expected behaviour are in
> {{AbstractContractOpenTest}} and {{AbstractContractSeekTest}}
> also, the {{HasEnhancedByteBufferAccess}} implementations may want to think
> about using {{checkStream()}} before acting on a potentially closed stream.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
