[
https://issues.apache.org/jira/browse/HADOOP-9902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14101212#comment-14101212
]
Suresh Srinivas commented on HADOOP-9902:
-----------------------------------------
I reviewed the code the best I can. I only reviewed core hadoop and hdfs
changes. It is is really hard given some code formatting is mixed real
improvements etc. This is a change that could have been done in a feature
branch. [~aw], certainly reviews could have been made easier that way. That
said, thank you for cleaning up the scripts. It is looks much better now!
Comments:
# bin/hadoop not longer checks for hdfs commands portmap and nfs3. Is this
intentional?
# hadoop-daemon.sh usage no longer prints --hosts optional paramter in usage;
this is intentional right? Also does all daemons now support option status
along with start and stop?
# locating HADOOP_PREFIX is repeated in bin/hadoop and hadoop-daemon.sh (this
can be optimized in a future patch)
# start-all.sh and stop-all.sh exits with warning. Why retain code after that.
Expect users to delete the exit in the beginning?jj
# hadoop_error is not used in some cases and still echo is used.
# hadoop-env.sh - we should document the GC configuration for max, min, young
generation starting and max size. Also think that secondary namenode should
just be set to primary namenode settings. This can be done in another jira. BTW
nice job for explicitly specifying the overridable functionas in hadoop-env.sh!
# cowsay is cute. But can get annoying :). Hopefully hadoop_usage is in every
script (I checked, it is).
> Shell script rewrite
> --------------------
>
> Key: HADOOP-9902
> URL: https://issues.apache.org/jira/browse/HADOOP-9902
> Project: Hadoop Common
> Issue Type: Improvement
> Components: scripts
> Affects Versions: 3.0.0
> Reporter: Allen Wittenauer
> Assignee: Allen Wittenauer
> Labels: releasenotes
> Fix For: 3.0.0
>
> Attachments: HADOOP-9902-10.patch, HADOOP-9902-11.patch,
> HADOOP-9902-12.patch, HADOOP-9902-13-branch-2.patch, HADOOP-9902-13.patch,
> HADOOP-9902-14.patch, HADOOP-9902-2.patch, HADOOP-9902-3.patch,
> HADOOP-9902-4.patch, HADOOP-9902-5.patch, HADOOP-9902-6.patch,
> HADOOP-9902-7.patch, HADOOP-9902-8.patch, HADOOP-9902-9.patch,
> HADOOP-9902.patch, HADOOP-9902.txt, hadoop-9902-1.patch, more-info.txt
>
>
> Umbrella JIRA for shell script rewrite. See more-info.txt for more details.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
