[ 
https://issues.apache.org/jira/browse/HADOOP-10710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14038066#comment-14038066
 ] 

Alejandro Abdelnur edited comment on HADOOP-10710 at 6/19/14 11:01 PM:
-----------------------------------------------------------------------

arghh, you right, it does not, only prints path/domain.

Then i wouldn't bother using JDK HttpCookie. I would simply make the value to 
be printed between double quotes and add also the {{; Version=1}} attribute.


was (Author: tucu00):
arghh, you right, it does not, only prints path/domain.

Then i wouldn't bother using JDK HttpCookie. I would simply make the value to 
be printed between double quotes and add also the {Version=1} attribute.

> hadoop.auth cookie is not properly constructed according to RFC2109
> -------------------------------------------------------------------
>
>                 Key: HADOOP-10710
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10710
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: security
>    Affects Versions: 2.4.0
>            Reporter: Alejandro Abdelnur
>            Assignee: Juan Yu
>         Attachments: HADOOP-10710.001.patch, HADOOP-10710.002.patch
>
>
> It seems that HADOOP-10379 introduced a bug on how hadoop.auth cookies are 
> being constructed.
> Before HADOOP-10379, cookies were constructed using Servlet's {{Cookie}} 
> class and corresponding {{HttpServletResponse}} methods. This was taking care 
> of setting attributes like 'Version=1' and double-quoting the cookie value if 
> necessary.
> HADOOP-10379 changed the Cookie creation to use a {{StringBuillder}} and 
> setting values and attributes by hand. This is not taking care of setting 
> required attributes like Version and escaping the cookie value.
> While this is not breaking HadoopAuth {{AuthenticatedURL}} access, it is 
> breaking access done using {{HtttpClient}}. I.e. Solr uses HttpClient and its 
> access is broken since this change.
> It seems that HADOOP-10379 main objective was to set the 'secure' attribute. 
> Note this can be done using the {{Cookie}} API.
> We should revert the cookie creation logic to use the {{Cookie}} API and take 
> care of the security flag via {{setSecure(boolean)}}.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to