[
https://issues.apache.org/jira/browse/HADOOP-6350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14029641#comment-14029641
]
Arpit Agarwal edited comment on HADOOP-6350 at 6/12/14 7:15 PM:
----------------------------------------------------------------
Thanks for clearing that up!
I am +1 on the HDFS/common changes however I don't feel qualified to review the
YARN metrics. Just a suggestion and if you agree, you can split this patch into
two:
# Part 1 introduces Metrics.apt.vm and documents all contexts except yarn and
mapred. I'd be happy to commit it.
# Part 2 adds yarn/mapred metrics to Metrics.apt.vm in a separate YARN jira.
What do you think?
was (Author: arpitagarwal):
Thanks for clearing that up!
I am +1 on the HDFS/common changes however I don't feel qualified to review the
YARN metrics. Just a suggestion and if you agree, you can split this patch into
two:
# Part 1 adds Metrics.apt.vm and documents all contexts except yarn and mapred.
I'd be happy to commit it.
# Part 2 documents yarn/mapred metrics in a separate YARN jira.
What do you think?
> Documenting Hadoop metrics
> --------------------------
>
> Key: HADOOP-6350
> URL: https://issues.apache.org/jira/browse/HADOOP-6350
> Project: Hadoop Common
> Issue Type: Improvement
> Components: documentation, metrics
> Affects Versions: 3.0.0, 2.1.0-beta
> Reporter: Hong Tang
> Assignee: Akira AJISAKA
> Labels: metrics
> Attachments: HADOOP-6350-sample-1.patch, HADOOP-6350-sample-2.patch,
> HADOOP-6350-sample-3.patch, HADOOP-6350.4.patch, HADOOP-6350.5.patch,
> HADOOP-6350.6.patch, HADOOP-6350.7.patch, HADOOP-6350.8.patch, sample1.png
>
>
> Metrics should be part of public API, and should be clearly documented
> similar to HADOOP-5073, so that we can reliably build tools on top of them.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
